I use vscode and there is a .vscode/setting.json file. It has some flake8 settings which probably need to be deleted. In my environment, I have ruff and pylance (which uses pyright) installed. What probably isn't correct is the settings for these. I see you added something for pyright, but does something need to be added for ruff?

Can you add/change the appropriate settings in .vscode/setting.json along with whatever should be in the requirements.txt file (I think) for pre-commit. I haven't used that before but it does sound useful.

I'll ask @RyanMcCleary to update .vscode/setting.json.
This repo doesn't appear to use a requirements.txt - instead we've noted dependencies in pyproject.toml

This repo doesn't appear to use a requirements.txt - instead we've noted dependencies in pyproject.toml

Does this mean I don't need to do anything for pre-commit or that I should create a requirements.txt file move the dependencies there along with adding something for pre-commit? Until just now, I wasn't aware of this file but it is certainly something that is useful.

For pre-commit, it looks there needs to be a .pre-commit-config.yaml file. Could you add something that is compatible with what NVDA uses?

@NSoiffer - you need to install and set up pre-commit locally.
I don't know what system you prefer to deal with managing a python dev environment. We use uv - I can ask Ryan to setup uv for MathCAT if you wish.
I don't think a requirements.txt file should be used - but if that's your preference I can ask Ryan to move dependencies from pyproject.toml over to a requirements.txt file.

NVDA uses .pre-commit-config.yaml. Ryan has created rules in this .pre-commit-config.yaml which matches closely what we use in NVDA to make it so the final PR to NVDA passes our pre-commit checks.

Thanks for all your help. I think I told Sean a while back that python is far from my "first" language and so my build environment was rather ad-hoc.